feat(Search): OnSearch callback support async #5000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThe pull request refactors the Search component to support a generic type parameter and an async OnSearch callback, allowing for more flexible and dynamic search operations. It also updates related unit tests and sample components to align with these changes. Additionally, the AutoFill component's Template parameter is deprecated in favor of ItemTemplate, and the OnSearch method in the Coms component is adjusted to handle nullable strings. Sequence diagram for Search component interactionsequenceDiagram
participant U as User
participant S as Search~TValue~
participant C as OnSearch Callback
U->>S: Enter search text
S->>S: Update _displayText
U->>S: Click search button
S->>S: Set loading icon
S->>C: OnSearch(_displayText)
C-->>S: Return IEnumerable~TValue~
S->>S: Update FilterItems
S->>S: Reset button icon
alt IsAutoClearAfterSearch is true
S->>S: Clear _displayText
end
S->>S: Show filtered items
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5000 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 27907 27917 +10
Branches 3991 3993 +2
=========================================
+ Hits 27907 27917 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnSearch callback support async
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4967
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add async support to the OnSearch callback in the Search component and introduce a generic type parameter for enhanced type safety. Update related unit tests to reflect these changes.
New Features:
Enhancements:
Tests: